fix: flatten filename for workspace

moltar · Feb 16, 2022 · 7614967 · 7614967
1 parent 1338fc5
commit 7614967
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -479,7 +479,8 @@ export class TurborepoProject extends typescript.TypeScriptProject {
 
       // Adds VS Code settings for ESLint to recognize sub-projects
       // https://github.com/Microsoft/vscode-eslint#settings-options
-      new JsonFile(this, `${this.name}.code-workspace`, {
+      const codeWorkspaceFilename = this.name.split('/').join('-')
+      new JsonFile(this, `${codeWorkspaceFilename}.code-workspace`, {
         obj: vscodeConfig,
       })
     }

diff --git a/test/__snapshots__/sub-projects.test.ts.snap b/test/__snapshots__/sub-projects.test.ts.snap
diff --git a/test/sub-projects.test.ts b/test/sub-projects.test.ts
@@ -50,20 +50,20 @@ describe('TurborepoProject', () => {
     expect.assertions(1)
 
     const project = createProject({
-      name: 'root',
+      name: '@foo/root',
       vscodeMultiRootWorkspaces: true,
     })
 
     const subProjectDir = 'packages/baz'
     createSubProject({
-      name: 'sub',
+      name: '@foo/sub',
       parent: project,
       outdir: subProjectDir,
     })
 
     const synth = synthProjectSnapshot(project)
 
-    expect(JSON.parse(synth[`${project.name}.code-workspace`])).toMatchSnapshot()
+    expect(JSON.parse(synth['@foo-root.code-workspace'])).toMatchSnapshot()
   })