Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 2021 edition, bless tests #339

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Nov 9, 2023

  • Move to edition 2021, and remove redundant use in test
  • run tests with TRYBUILD=overwrite

* Move to edition 2021, and remove redundant `use` in test
* run tests with `TRYBUILD=overwrite`
@tatsuya6502
Copy link
Member

Thank you very much for submitting a PR!

I believe we can ignore the failing tests:

@tatsuya6502 tatsuya6502 mentioned this pull request Nov 9, 2023
@nyurik
Copy link
Contributor Author

nyurik commented Nov 9, 2023

see #341 -- it should fix this

@tatsuya6502 tatsuya6502 self-requested a review November 9, 2023 22:51
@tatsuya6502 tatsuya6502 added this to the v0.12.2 milestone Nov 9, 2023
Copy link
Member

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. It looks good to me.

@tatsuya6502 tatsuya6502 added this pull request to the merge queue Nov 9, 2023
Merged via the queue into moka-rs:main with commit 31cfe4d Nov 9, 2023
6 of 16 checks passed
@nyurik nyurik deleted the ed2021 branch November 9, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants