Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An examples directory is added to allow cargo to run the given exampl… #268

Merged
merged 1 commit into from
May 27, 2023
Merged

An examples directory is added to allow cargo to run the given exampl… #268

merged 1 commit into from
May 27, 2023

Conversation

peter-scholtens
Copy link
Contributor

An examples directory is added to allow cargo to run the given examples. The earlier documented sync and async examples are added as also a size-aware-eviction and an eviction-listener example to demonstrate the subtleties of the cache behavior.
For CI purposes the required-features of these examples are defined in Cargo.toml.
Update README.md

…es. The earlier documented sync and async examples are added as also a size-aware-eviction and an eviction-listener example to demonstrate the subtleties of the cache behavior.

For CI purposes the required-features of these examples are defined in Cargo.toml.
Update README.md
@tatsuya6502 tatsuya6502 self-assigned this May 27, 2023
@tatsuya6502 tatsuya6502 self-requested a review May 27, 2023 07:57
@tatsuya6502 tatsuya6502 added the documentation Improvements or additions to documentation label May 27, 2023
@tatsuya6502
Copy link
Member

Thank you for submitting this PR! I will review and merge it.

@tatsuya6502
Copy link
Member

This CI failure should not be related to this PR. I will ignore the failure now, and try to fix it in a separate PR.

Miri tests / test (pull_request) Failing after 57s

https://github.com/moka-rs/moka/actions/runs/5097752880/jobs/9164484355?pr=268

Copy link
Member

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks!

@tatsuya6502 tatsuya6502 added this pull request to the merge queue May 27, 2023
Merged via the queue into moka-rs:master with commit 992584b May 27, 2023
@tatsuya6502 tatsuya6502 added this to the v0.11.1 milestone May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants