Change get_or_try_insert_with to return a concrete error type rather than a trait object #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
get_or_try_insert_with
ofsync::{Cache, SegmentedCache}
andfuture::Cache
to return a concrete error type rather than a trait object.Before (
sync::Cache
)After
Behavior Change
There is a subtle change in the behavior.
get_or_try_insert_with
used to guarantee that the closureF
to evaluate once even if multiple threads call it at the same time on the same cache key.Now this is not always true: