Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate any_slice #2789

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Deprecate any_slice #2789

merged 3 commits into from
Sep 26, 2023

Conversation

zhassan-aws
Copy link
Contributor

Description of changes:

See #2788 for details.

Resolved issues:

Resolves #2788
Resolves #2634

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested? Added one test

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws zhassan-aws requested a review from a team as a code owner September 25, 2023 18:11
feliperodri
feliperodri approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@feliperodri feliperodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

celinval
celinval requested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the usage of any_slice in our tests

@zhassan-aws
Copy link
Contributor Author

Please replace the usage of any_slice in our tests

Done.

celinval
celinval approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions github-actions bot added the Z-BenchCI Tag a PR to run benchmark CI label Sep 26, 2023
@zhassan-aws zhassan-aws merged commit 8480dc6 into model-checking:main Sep 26, 2023
13 checks passed
@zhassan-aws zhassan-aws deleted the deprecate-any-slice branch September 26, 2023 06:02
@zhassan-aws zhassan-aws mentioned this pull request Sep 26, 2023
Closed
@zhassan-aws zhassan-aws mentioned this pull request Nov 6, 2023
Merged
zhassan-aws added a commit that referenced this pull request Nov 7, 2023
@zhassan-aws
Delete any_slice which has been deprecated since Kani 0.38.0. (#2860)
985021f 
Kani's `any_slice` function (and related code) has been deprecated since
Kani 0.38.0 (see #2789). This PR officially obsoletes it by deleting the
code.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celinval celinval celinval approved these changes

@feliperodri feliperodri feliperodri approved these changes

Assignees
No one assigned
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate kani::slice::any_slice Proof with AnySlice does not terminate, memory grows unbounded
3 participants
@zhassan-aws @feliperodri @celinval