Modify FunctionGetOutputs proto for client retries #2577
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~This is based on #2403. That should me reviewed and merged first. ~
Update: That PR has been merged, and this one has been rebased on it.
This modifies the request and response of FunctionGetOutputs so the client can retry lost inputs. This applies to sync inputs only.
The request has a new field
expected_input_ids
, so the client can optionally pass the server a list of input ids that it expects the server to be processing.The server will check if it has a record of all these IDs. If not, it will immediately return, populating the response's new
lost_input_ids
field with the IDs that missing. The client can the resend those inputs.Merging the proto changes first so we can implement and test this in the server.
Part of SVC-171
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
Changelog