Add _is_web_endpoint attr to _Function
#2520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add
_is_web_endpointattr to_Function. The point of_is_web_endpointis to be able to determine if a_Functionis a web function when it is un-hydrated and._web_urlis not populated.The motivation for this change is that PR 2364 also modifies
_add_functionto properly populate_App.web_endpointswhen called on a new-style class service function that has_method_functionspopulated. This is necessary because for these new-style classes without method placeholder functions there won't be any invocations of_add_functionfor the class methods.