Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf: invocation type on input given to client #2519

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

gongy
Copy link
Contributor

@gongy gongy commented Nov 15, 2024

Describe your changes

  • Provide Linear issue reference (e.g. MOD-1234) if available.
Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

@gongy gongy requested a review from mwaskom November 15, 2024 19:07
@gongy
Copy link
Contributor Author

gongy commented Nov 15, 2024

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @mwaskom will follow-up review this.

@gongy gongy merged commit b53b8d2 into main Nov 15, 2024
19 of 20 checks passed
@gongy gongy deleted the richard/add-invocation-type-to-get-inputs-item branch November 15, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants