uncaughtException: fix recovery when current test is still running

[juergba]

Description

describe('uncaught', function() {
  it('throw delayed error', (done) => {
    setTimeout(() => {
      throw new Error('Whoops!');
    }, 10)
    setTimeout(done, 10);
  });
  it('should wait 15ms', (done) => {      
    setTimeout(done, 15);
  });
  it('test 3', () => { });

  afterEach(function() {
    console.log('inside afterEach:', this.currentTest.title);
  });
});

This bug produces very variable results as throwing TypeError and failing empty tests. In above example the output is complete nonsense.

uncaught
    1) throw delayed error                  // first test fails
    √ throw delayed error                   // then same test passes
inside afterEach: throw delayed error      // same hook twice 
inside afterEach: throw delayed error
    √ test 3                                // second test is missing
    √ test 3                                // third test runs twice
inside afterEach: test 3                   // same hook twice 
inside afterEach: test 3

  3 passing (41ms)
  1 failing

  1) uncaught
        throw delayed error:
      Uncaught Error: Whoops!
      [...]

Fixed output:

uncaught
    1) throw delayed error
    2) throw delayed error
inside afterEach: throw delayed error
    √ should wait 15ms
inside afterEach: should wait 15ms
    √ test 3
inside afterEach: test 3

  2 passing (62ms)
  2 failing

  1) uncaught
       throw delayed error:
      Uncaught Error: Whoops!
      [...]
  2) uncaught
       throw delayed error:
      Error: done() called multiple times
      [...]

Description of the Change

We remove the recovery of a failing open test out of Runner#uncaught and pass the error to runnable's callback. done finishes the runnable and triggers the standard error handling incl. hook pattern.

Applicable issues

closes #2906, see comment

[coveralls]

Coverage remained the same at 92.857% when pulling 0250f67 on juergba/recover-uncaught into 9c10ada on master.

[juergba]

@weswigham your testing would be welcome.

[craigtaub]

Tried locally and I like it. Code makes sense. Like the additional tests. LGTM