Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for TAP reporter when given invalid reporter option #3673

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Add test for TAP reporter when given invalid reporter option #3673

merged 1 commit into from
Jan 17, 2019

Conversation

plroebuck
Copy link
Contributor

Description of the Change

  • Added test for invalid reporter option for tapVersion
  • Updated other TAP tests' cmdline args to use --reporter-option instead of --reporter-options

Alternate Designs

NA

Why should this be in core?

NA

Benefits

This test was missing from PR which introduced the tapVersion reporter option.
Increased coverage!

Possible Drawbacks

NA

Applicable issues

SeeAlso #3552
semver-patch

@plroebuck
test(integration/reporters.spec.js): Add test for TAP when given inva…
2f137b2 
…lid reporter option

Added test for invalid reporter option for `tapVersion`.
@plroebuck plroebuck added area: reporters involving a specific reporter qa semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Jan 16, 2019
@plroebuck plroebuck added this to the v6.0.0 milestone Jan 16, 2019
@plroebuck plroebuck self-assigned this Jan 16, 2019
@plroebuck plroebuck requested a review from boneskull January 16, 2019 13:54
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 90.811% when pulling 2f137b2 on plroebuck/test-invalid-tap-version into e2d4929 on master.

@plroebuck plroebuck added the status: needs review a maintainer should (re-)review this pull request label Jan 17, 2019
boneskull
boneskull approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ty

@boneskull boneskull merged commit c838315 into master Jan 17, 2019
@boneskull boneskull removed the status: needs review a maintainer should (re-)review this pull request label Jan 17, 2019
@plroebuck plroebuck deleted the plroebuck/test-invalid-tap-version branch January 18, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boneskull boneskull boneskull approved these changes

Assignees

@plroebuck plroebuck

Labels
area: reporters involving a specific reporter semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@plroebuck @coveralls @boneskull