-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🛠 Repo: Remove husky
for now
#5124
Comments
Err, remove or fix? My preference would be to use it to enforce formatting on Git commit, and remove any linting. |
Explaining why I'm not in favor of this: Husky makes it a lot harder (admittedly, not impossible) to make commits locally that aren't well-formatted. Not every contributor uses a nicely set up editor like VS Code with format-on-save. They might be new to development, and/or using something like Nodepad++, and/or just running with odd settings. For those edge cases, it's inconvenient to have to be told by CI that your change has formatting issues. So from my perspective, there's very little downside to setting up formatting as a Git commit hook locally ( Which brings up a question: why do you two want to remove it? Assuming we're sticking to formatting on commit hooks and not linting or other more intrusive and/or time-intensive tasks... why not? |
I use husky on all of my own projects so I’m totally up for keeping it. I can’t remember exact reason why we discussed dropping it |
Tooling Suggestion Checklist
master
branch of the repository.faq
label, but none matched my issue.Overview
As mentioned in #5042 (comment), we decided to remove
husky
for now. Might re-add later.Additional Info
No response
The text was updated successfully, but these errors were encountered: