6.2.1 fails for node 8.x if there is a --require

[cabbiepete]

Prerequisites

• Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
• Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
• 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
• Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend that you not install Mocha globally.

Description

6.2.0 the command below works

NODE_ENV=test PORT=9999 node_modules/.bin/mocha -t 5000 --require esm --exit -b --recursive server/test/bootstrap.test.js

with 6.2.1 if fails with this output on Node 8.x (NB: works on Node 10.x for both)

bad option: --require=esm

Node 8.x expects the require to be in this format --require esm i.e. no equals = sign

I can workaround this by running the underlying node more directly but wanted to let you know about this small regression.

Steps to Reproduce

See description

Expected behavior: [What you expect to happen]

See description

Actual behavior: [What actually happens]

See description

Reproduces how often: 100%

Versions

• The output of mocha --version and node node_modules/.bin/mocha --version:
  No global install and local is 6.2.1

• The output of node --version: v8.16.1

• Your operating system

  • name and version: Mac OS Mojave 10.14.6 also fails on CircleCI node 8 image which I think is Alpine
  • architecture (32 or 64-bit): 64-bit

• Your shell (e.g., bash, zsh, PowerShell, cmd): zsh

• Your browser and version (if running browser tests): N/A

• Any third-party Mocha-related modules (and their versions): None

• Any code transpiler (e.g., TypeScript, CoffeeScript, Babel) being used (and its version): none / ESM as a loader

Additional Information

[boneskull]

I just hit this; will fix.

[boneskull]

probably 5f1cad5

[boneskull]

no, it's not directly responsible, but exposed the bug

[boneskull]

see #4063

[cabbiepete]

Thanks