Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --forbid-only (but not --forbid-pending) default in CI #3030

Open
ScottFreeCode opened this issue Sep 29, 2017 · 7 comments
Open

Make --forbid-only (but not --forbid-pending) default in CI #3030

ScottFreeCode opened this issue Sep 29, 2017 · 7 comments
Labels
semver-major implementation requires increase of "major" version number; "breaking changes" status: accepting prs Mocha can use your help with this one!

Comments

@ScottFreeCode
Copy link
Contributor

Eventually let's make --forbid-only the default and use --no-forbid-only to disable it. Lots of CI will get safer for free!

(Pending, on the other hand, isn't so dangerous to begin with and has more long-term use-cases. It'll be inconsistent, but let's leave pending as-is.)

@ScottFreeCode ScottFreeCode added the semver-major implementation requires increase of "major" version number; "breaking changes" label Sep 29, 2017
@boneskull
Copy link
Contributor

Actually, this is fine if we make --forbid-only the default if the CI environment var is present.

@parksb
Copy link
Contributor

parksb commented Jun 29, 2019

I agree with making --forbid-only the default on CI environment. Can I take this issue?

@outsideris
Copy link
Contributor

@parksb Yes, you can.

JaeHyeonKim19 added a commit to JaeHyeonKim19/mocha that referenced this issue Aug 16, 2019
JaeHyeonKim19 added a commit to JaeHyeonKim19/mocha that referenced this issue Oct 26, 2019
Test cases broken because of making forbid-only as default in CI..
@github-actions
Copy link
Contributor

This issue hasn't had any recent activity, and I'm labeling it stale. Remove the label or comment or this issue will be closed in 14 days. Thanks for contributing to Mocha!

@github-actions github-actions bot added the stale this has been inactive for a while... label Mar 28, 2021
@outsideris outsideris removed the stale this has been inactive for a while... label Mar 31, 2021
@github-actions
Copy link
Contributor

This issue hasn't had any recent activity, and I'm labeling it stale. Remove the label or comment or this issue will be closed in 14 days. Thanks for contributing to Mocha!

@github-actions github-actions bot added the stale this has been inactive for a while... label Jul 30, 2021
@JoshuaKGoldberg JoshuaKGoldberg added status: in triage a maintainer should (re-)triage (review) this issue and removed stale this has been inactive for a while... labels Feb 29, 2024
@JoshuaKGoldberg
Copy link
Member

I'm in favor of this as a changed default for CI environments. It's better to have safety be opt-in IMO. This is what Vitest does and it's quite useful.

@JoshuaKGoldberg JoshuaKGoldberg changed the title Make --forbid-only (but not --forbid-pending) default Make --forbid-only (but not --forbid-pending) default in CI Oct 8, 2024
@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Oct 8, 2024

Forbidding .only in CI is a good safe practice that other test frameworks do in CI (e.g. https://vitest.dev/config/#allowonly). Marking as accepting PRs for Mocha.

Note that it'd be a breaking change, so we wouldn't be able to merge for a while.

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Mocha can use your help with this one! and removed status: in triage a maintainer should (re-)triage (review) this issue labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major implementation requires increase of "major" version number; "breaking changes" status: accepting prs Mocha can use your help with this one!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants