-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make --forbid-only (but not --forbid-pending) default in CI #3030
Comments
Actually, this is fine if we make |
I agree with making |
@parksb Yes, you can. |
Test cases broken because of making forbid-only as default in CI..
This issue hasn't had any recent activity, and I'm labeling it |
This issue hasn't had any recent activity, and I'm labeling it |
I'm in favor of this as a changed default for CI environments. It's better to have safety be opt-in IMO. This is what Vitest does and it's quite useful. |
Forbidding Note that it'd be a breaking change, so we wouldn't be able to merge for a while. |
Eventually let's make
--forbid-only
the default and use--no-forbid-only
to disable it. Lots of CI will get safer for free!(Pending, on the other hand, isn't so dangerous to begin with and has more long-term use-cases. It'll be inconsistent, but let's leave pending as-is.)
The text was updated successfully, but these errors were encountered: