Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mocha --help gets it's output cut off. #2471

Closed
Jontem opened this issue Sep 4, 2016 · 4 comments
Closed

mocha --help gets it's output cut off. #2471

Jontem opened this issue Sep 4, 2016 · 4 comments
Labels
status: wontfix typically a feature which won't be added, or a "bug" which is actually intended behavior

Comments

@Jontem
Copy link

Jontem commented Sep 4, 2016 •
edited
Loading

Hi!

In my osx terminal i get the output of running mocha --help cut off.
screen shot 2016-09-04 at 16 41 57

I've tested on windows command-line and it works there.

Node: 6.2.0
Mocha: 3.0.2

Edit: I upgraded to node 6.5.0. And it now seems to work.
@boneskull boneskull added type: bug a defect, confirmed by a maintainer confirmed labels Sep 14, 2016
@boneskull
Copy link
Contributor

boneskull commented Sep 14, 2016 •
edited
Loading

I can confirm this bug is present in Node.js 6.0.0 through 6.2.0. Neither Node.js <= 5.12.0 nor >= 6.2.1 exhibit this behavior. Whether or not we can do anything about it is anyone's guess. Would like to know why this happens, at any rate...

@boneskull boneskull added the status: accepting prs Mocha can use your help with this one! label Sep 14, 2016
@ISNIT0
Copy link

ISNIT0 commented Oct 19, 2016

I'd imagine this is related to nodejs/node#6297

Lots of packages seem to have had a similar problem.

UglifyJS fixed it as so: https://github.com/mishoo/UglifyJS2/pull/1061/files
I'm not sure if that's the kind of fix (slightly adhoc) that would be appropriate in Mocha, maybe someone who knows the code base better could check it out?

@boneskull
Copy link
Contributor

could probably do that, yes

@dasilvacontin dasilvacontin self-assigned this Oct 31, 2016
dasilvacontin added a commit that referenced this issue Oct 31, 2016
@dasilvacontin
Avoid output truncation in node 5.12.1-6.2.0
617b0f0 
As reported in #2471, the `help` command's output was being cut off.
Streams were probably being cut off in other cases too.

Solution borrowed from mishoo/UglifyJS#1061.

Closes #2471.
@dasilvacontin dasilvacontin mentioned this issue Oct 31, 2016
Closed
@ScottFreeCode ScottFreeCode mentioned this issue Nov 2, 2016
Merged
@juergba juergba added the stale this has been inactive for a while... label Mar 6, 2019
@stale stale bot removed the stale this has been inactive for a while... label Mar 6, 2019
@juergba juergba added the stale this has been inactive for a while... label Mar 6, 2019
@boneskull
Copy link
Contributor

I'm gonna call this one. it's not worth bothering with; it affects a certain range of node v6 on certain environments, and has long since been fixed upstream.

@boneskull boneskull added status: wontfix typically a feature which won't be added, or a "bug" which is actually intended behavior and removed type: bug a defect, confirmed by a maintainer status: accepting prs Mocha can use your help with this one! stale this has been inactive for a while... labels Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: wontfix typically a feature which won't be added, or a "bug" which is actually intended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@boneskull @dasilvacontin @Jontem @ISNIT0 @juergba