fix xunit reporter crash when used with parallel mode

mochajs · Apr 7, 2021 · 8261ea8 · 8261ea8
1 parent d7ed5c2
commit 8261ea8
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 18 deletions.
diff --git a/lib/hook.js b/lib/hook.js
@@ -62,22 +62,18 @@ Hook.prototype.error = function(err) {
  */
 Hook.prototype.serialize = function serialize() {
   return {
-    $$isPending: this.isPending(),
+    $$isPending: !!this.isPending(),
     $$titlePath: this.titlePath(),
     ctx:
       this.ctx && this.ctx.currentTest
         ? {
-            currentTest: {
-              title: this.ctx.currentTest.title,
-              [MOCHA_ID_PROP_NAME]: this.ctx.currentTest.id
-            }
+            currentTest: this.ctx.currentTest.serialize()
           }
         : {},
-    parent: {
-      [MOCHA_ID_PROP_NAME]: this.parent.id
-    },
+    parent: this.parent.serialize(),
+    state: this.state,
     title: this.title,
     type: this.type,
-    [MOCHA_ID_PROP_NAME]: this.id
+    [MOCHA_ID_PROP_NAME]: this[MOCHA_ID_PROP_NAME]
   };
 };
diff --git a/lib/suite.js b/lib/suite.js
@@ -594,11 +594,11 @@ Suite.prototype.serialize = function serialize() {
   return {
     _bail: this._bail,
     $$fullTitle: this.fullTitle(),
-    $$isPending: this.isPending(),
+    $$isPending: !!this.isPending(),
     root: this.root,
     title: this.title,
-    id: this.id,
-    parent: this.parent ? {[MOCHA_ID_PROP_NAME]: this.parent.id} : null
+    parent: this.parent ? this.parent.serialize() : null,
+    [MOCHA_ID_PROP_NAME]: this[MOCHA_ID_PROP_NAME]
   };
 };
 

diff --git a/lib/test.js b/lib/test.js
@@ -92,22 +92,19 @@ Test.prototype.serialize = function serialize() {
   return {
     $$currentRetry: this._currentRetry,
     $$fullTitle: this.fullTitle(),
-    $$isPending: this.pending,
+    $$isPending: !!this.pending,
     $$retriedTest: this._retriedTest || null,
     $$slow: this._slow,
     $$titlePath: this.titlePath(),
     body: this.body,
     duration: this.duration,
     err: this.err,
-    parent: {
-      $$fullTitle: this.parent.fullTitle(),
-      [MOCHA_ID_PROP_NAME]: this.parent.id
-    },
+    parent: this.parent.serialize(),
     speed: this.speed,
     state: this.state,
     title: this.title,
     type: this.type,
     file: this.file,
-    [MOCHA_ID_PROP_NAME]: this.id
+    [MOCHA_ID_PROP_NAME]: this[MOCHA_ID_PROP_NAME]
   };
 };