chore: fix test workflow isolation #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabdya767
approved these changes
Feb 5, 2024
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
requested changes
Jul 4, 2024
matiassimon
force-pushed
the
tests-workflow-isolation
branch
from
270d629 to
e720653
Compare
Co-authored-by: Josh Goldberg ✨ <[email protected]>
Co-authored-by: Josh Goldberg ✨ <[email protected]>
Co-authored-by: Josh Goldberg ✨ <[email protected]>
|
Ah! I was waiting to be re-requested for review. But looks like this is ready for review. |
JoshuaKGoldberg
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Looks great to me, thanks @matiassimon! 🚀
The echo command is a bit intense 😄 but I think this is fine.
JoshuaKGoldberg
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Err, looking at https://github.com/mochajs/mocha-examples/actions/runs/11238784553/job/31244347723 & co., it looks like these aren't actually running tests? @matiassimon something must have gotten borked in the updates. Could you please take a look?
Annotations
3 errors
Error when evaluating 'strategy' for job 'test'. mochajs/mocha-examples/.github/workflows/test-workflow.yml@5b8715b610c842673e674934abaa4acc707fcc3a (Line: 28, Col: 18): Error parsing fromJson,mochajs/mocha-examples/.github/workflows/test-workflow.yml@5b8715b610c842673e674934abaa4acc707fcc3a (Line: 28, Col: 18): Error reading JToken from JsonReader. Path '', line 0, position 0.,mochajs/mocha-examples/.github/workflows/test-workflow.yml@5b8715b610c842673e674934abaa4acc707fcc3a (Line: 28, Col: 18): Unexpected value ''
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matrix strategy solution. Fixes #78.