dockerfile: fix named context replacement for child stages #5596
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug that didn't allow named context replacement for stages that were inherited from another stage. This is a regression from Dockerfile 1.11 ONBUILD changes where code was changed to call init() later to allow ONBUILD rules to change the dependency list of a stage. Calling this reinit caused the child stage to pick up the its state from the parent stage in Dockerfile again. Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
dockerfile-fixed-named-context-parent-stage
branch
from
b54619e to
4c8bd43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug that didn't allow named context replacement for stages that were inherited from another stage.
This is a regression from Dockerfile 1.11 ONBUILD changes where code was changed to call init() later to allow ONBUILD rules to change the dependency list of a stage. Calling this reinit caused the child stage to pick up its state from the parent stage in Dockerfile again.
fixes #5578 (comment)
@mzihlmann