Make local cache importer non-lazy #3493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kohei Tokunaga <[email protected]>
|
@tonistiigi I think we discussed possibly adding this same fix into the oci-layout:// code? I think it suffers from the same problem here, but can't quite see where that needs to plug-in. |
crazy-max
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
I checked the behavior with docker/buildx#1325 repro and LGTM thanks @ktock
@sipsma PTAL if you have time 🙏
tonistiigi
approved these changes
Jan 26, 2023
|
Does this issue impact |
|
EDIT: I'm not sure docker/buildx#1325 happens on v0.10 as well. Please post an issue if you see it. |
This was referenced Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another approach for solving #3229 and docker/buildx#1325
Quote from #3229:
The difference between this and #3229 is that this PR fixes that issue by making the local cache importer non-lazy so this is simpler implementation than #3229 . As soon as the cache record is created, it is unlazied using the session provided from the importer.