Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DistanceMatrix): fromCompact with an empty array #188

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix(DistanceMatrix): fromCompact with an empty array #188

merged 2 commits into from
Jun 10, 2024

Conversation

tpoisseau
Copy link
Contributor

It was creating a distance matrix
with 1 as diagonalSize instead 0

@tpoisseau
fix(DistanceMatrix): fromCompact with an empty array
aa0c7ba 
It was creating a distance matrix
with `1` as `diagonalSize` instead `0`
@tpoisseau tpoisseau requested a review from targos June 10, 2024 14:58
@targos targos linked an issue Jun 10, 2024 that may be closed by this pull request
DistanceMatrix.fromCompact([]) creates a 1x1 matrix #187
Closed
@targos
Copy link
Member

targos commented Jun 10, 2024

Can you fix the ESLint errors in a separate commit?

@tpoisseau
Copy link
Contributor Author

I had to remove my node_modules, then npm i to reproduce lint errors :/

targos
targos approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@targos targos merged commit 32bd7d2 into main Jun 10, 2024
7 checks passed
@targos targos deleted the fix/distance-matrix-fromcompact-empty branch June 10, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DistanceMatrix.fromCompact([]) creates a 1x1 matrix
2 participants
@tpoisseau @targos