Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade ubuntu VMs from 20.04 to 22.04 #4857

Merged
merged 3 commits into from
Jul 22, 2022

Conversation

Swiftb0y
Copy link
Member

@Swiftb0y Swiftb0y commented Jul 15, 2022

As per our minimum requirement policy and https://wiki.ubuntu.com/Releases, this can be merged On August 4th when Ubuntu 22.04.1 gets released.
Lets merge this ASAP. I added an extra 22.04 VM instead of upgrading. This way we can verify main continues to work while we can also make sure that C++20 code actually works.
Putting as draft until then.
The pre-commit error is simply bogus.

@Swiftb0y
Copy link
Member Author

fixed clazy. Still don't know what to do about pre-commit.
I'll try to take care of the extra VM in this PR too

@Swiftb0y Swiftb0y force-pushed the upgrade-ubuntu-ci-jammy branch from 26c5d07 to 14c9c97 Compare July 20, 2022 16:19
@Swiftb0y
Copy link
Member Author

fixed pre-commit. Turns out the schema was simply outdated/buggy.

@Swiftb0y Swiftb0y marked this pull request as ready for review July 20, 2022 16:23
@Swiftb0y Swiftb0y requested a review from daschuer July 20, 2022 16:24
@Swiftb0y Swiftb0y mentioned this pull request Jul 22, 2022
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the extra mile of an additional runner.

@daschuer daschuer merged commit 5e16a3a into mixxxdj:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants