WTrackMenu: enable Reset Loops action #4802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested on the forums + https://bugs.launchpad.net/mixxx/+bug/1978507
"Reset loops" was already in place but deactivated (though included in "Reset All" :| )
In 2.3 this does nothing as the FIXME says, in main it clears the saved loop cues -- though the last active loop persists, no matter if it had a loop cue attached.
extent to clear the last active loop (markers removed,
reloopdetached)loop_removecontrol (saved loops are not touched)Should we distinguish between saved loops and the current active loop?
The latter is requested on the forums now & then, though users are not aware of saved loops in 2.4, and with that there's at least a workaround to clear the unsaved loop (save, then delete loop cue)