Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkmark in chain preset list on Windows #4748

Merged
merged 1 commit into from
May 9, 2022

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented May 8, 2022

MSVC treats c strings as Windows-1252

Warning: ..\src\widget\weffectchainpresetbutton.cpp(53): warning C4566: character represented by universal-character-name '\u2713' cannot be represented in the current code page (1252)

@github-actions github-actions bot added the ui label May 8, 2022
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Swiftb0y Swiftb0y merged commit 34c6a95 into mixxxdj:main May 9, 2022
@daschuer daschuer deleted the chain_preset_list branch November 16, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants