-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library track selection tweaks #4536
Conversation
f600fe8
to
8310d05
Compare
8310d05
to
ddcd895
Compare
Note: I marked it as draft because I'll likely rebase -- still want to test and work out some details. |
ddcd895
to
3c7298b
Compare
Actually, this is it. |
Saving only indexes is super annoying, thats why I implemented the IDs. I often use a filter like |
Sure. you can open a PR at my branch with that change (only) that also saves the focused column of the current TrackId's row because that's what I missed last time I tested it. Sooner or later I'll do it myself, but not in this PR |
3c7298b
to
400bb8f
Compare
Okay, now this works also if an invalid (invisible) column is passed to setCurrentTrack() in case it is invoked from somewhere else then onSearch(). |
@uklotzde |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot promise that there are no regression. But code looks good, so let's move on. Thank you! LGTM
However the local build with Qt 5.15 failed:
Fixed by #4609. |
follow-up of #4177, picking bites from #3063 to improve the track selection when changing features and search queries.