Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WEffectChainPresetSelector: don't set elide padding in c++ #4532

Merged
merged 1 commit into from
Nov 20, 2021
Merged

WEffectChainPresetSelector: don't set elide padding in c++ #4532

merged 1 commit into from
Nov 20, 2021

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Nov 20, 2021

No description provided.

@github-actions github-actions bot added the ui label Nov 20, 2021
@ronso0 ronso0 mentioned this pull request Nov 20, 2021
Merged
Be-ing
Be-ing approved these changes Nov 20, 2021
View reviewed changes
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I'm not sure where that magic - 2 came from...

@ronso0
Copy link
Member Author

ronso0 commented Nov 20, 2021

I adapted that from the popup elide calculation, which was adapted from WEffectSelector I guess, but in both popups the extra padding is not noticed and not as relevant as it is for the effect and preset selector.

@Be-ing Be-ing merged commit 81cbc21 into mixxxdj:main Nov 20, 2021
@ronso0 ronso0 deleted the fxpresetselector-elide branch November 20, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronso0 @Be-ing