Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LateNight: fixup width of Quick Effect popup #4518

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Nov 13, 2021

@JoergAtGithub Please test this
Supposed to look like this (on Linux, popup unrolls differently on Windows)
image

@JoergAtGithub
Copy link
Member

It looks much better now:
grafik
Opposite to your Linux screenshot it shows a vertical scrollbar and a useless tooltip. But now it's useable. Thank you!

@ronso0
Copy link
Member Author

ronso0 commented Nov 13, 2021

meeh, the highlight color is from the system theme.
Does the highlight in the selector in the effect units look the same?

@JoergAtGithub
Copy link
Member

Yes:
grafik
But what's different is the content of the tooltip. It has real information aboutthe effect.

@ronso0
Copy link
Member Author

ronso0 commented Nov 13, 2021

Yes, that is to be expected:

  • the effect selector has single effects. each effect has a manifest with a brief decsription.
  • effect chain selectors however can hold custom chains which do not necessarily have a description, thus the tooltip is the effect name (which may be elided in the effects list)

Would you mind filing a bug report so we can track that aspect?
maybe the effect chain configuration can be extended so that built-in chains have a description and user can add one to custom chains.

@ronso0
Copy link
Member Author

ronso0 commented Nov 13, 2021

okay, this can be merged.

I'll take another look at the colors. Thought we already managed to make it consistent on all platforms.

@JoergAtGithub
Copy link
Member

Would you mind filing a bug report so we can track that aspect?

Done: https://bugs.launchpad.net/mixxx/+bug/1950861

@ronso0
Copy link
Member Author

ronso0 commented Nov 13, 2021

Thanks!

@Be-ing
Copy link
Contributor

Be-ing commented Nov 13, 2021

Thanks

@Be-ing Be-ing merged commit b03b362 into mixxxdj:main Nov 13, 2021
@ronso0 ronso0 deleted the late-quickeffect-popup-width branch November 13, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants