Tweak WEffectChainPresetSelector #4501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 6, 2021
ronso0
force-pushed
the
fxrfct-chain-selector
branch
from
b9a1105 to
72cb3f2
Compare
In oficial skins the popup is much wider than the selector which previosly resulted in unnecessarily shortened effect names in the popup.
ronso0
force-pushed
the
fxrfct-chain-selector
branch
from
72cb3f2 to
7806776
Compare
daschuer
approved these changes
Nov 7, 2021
|
This has created a regression in Tango. There is hardly any contrast between the background of the combobox and the text when the menu is open: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prerequisite for the PRs with the actual skin implementation