Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EffectChain: make setting chain_preset_selector to 0 a no-op #4457

Merged
merged 1 commit into from
Oct 18, 2021
Merged

EffectChain: make setting chain_preset_selector to 0 a no-op #4457

merged 1 commit into from
Oct 18, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Oct 18, 2021

No description provided.

@Swiftb0y
Copy link
Member

I guess chain_preset_selector is a relative control?

@daschuer
Copy link
Member

No, it is intended to use -1 and +1 only.

daschuer
daschuer approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@daschuer daschuer merged commit 6367bf2 into mixxxdj:effects_refactoring Oct 18, 2021
@Swiftb0y
Copy link
Member

Weird design but ok.

@daschuer
Copy link
Member

That was designed for endless decoder knobs and just works.

@Be-ing Be-ing deleted the chain_preset_selector_0 branch October 18, 2021 18:19
@Swiftb0y
Copy link
Member

Makes sense from that PoV, but is kind of weird from a general-purpose perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Be-ing @Swiftb0y @daschuer