Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: check for Qt 5.12 #4423

Merged
merged 1 commit into from
Oct 14, 2021
Merged

CMake: check for Qt 5.12 #4423

merged 1 commit into from
Oct 14, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Oct 14, 2021 •
edited
Loading

Compile errors are nasty surprises that are difficult to troubleshoot. Minimum requirements should be explicitly checked by the build system so it can give useful error messages.

@github-actions github-actions bot added the build label Oct 14, 2021
uklotzde
uklotzde approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit e2c6089 into mixxxdj:main Oct 14, 2021
@Be-ing Be-ing deleted the qt5_12 branch October 14, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @uklotzde