fix ParserCSV build errors with Qt6 #4394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
suggested changes
Oct 13, 2021
src/library/parsercsv.cpp
Outdated
| // Using UTF-8 to get around codepage issues | ||
| // and it's the default encoding in Ooo Calc | ||
| // UTF-8 is the default in Qt6. | ||
| #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0) |
There was a problem hiding this comment.
The comment should be better replaced by a debug assertion:
#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)
DEBUG_ASSERT(out.encoding() == QStringConverter::Utf8);
#else
out.setCodec("UTF-8");
#endif
The implict conversion from QString to QFileInfo has been removed in Qt6.
QTextStream::setCodec was removed in Qt6. https://bugreports.qt.io/browse/QTBUG-75665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.