-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar: use item label for tooltip, show id when debugging #4247
Conversation
btw, Windows builds fail with CMake Error at C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.20/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
Could NOT find Chromaprint (missing: Chromaprint_LIBRARY
Chromaprint_INCLUDE_DIR)
Call Stack (most recent call first):
C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.20/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
cmake/modules/FindChromaprint.cmake:68 (find_package_handle_standard_args)
CMakeLists.txt:1787 (find_package) |
Rebase on 2.3? |
a736075
to
02e8198
Compare
I consider it a UX inconvenience/inconsistency not really a bug. |
02e8198
to
0ac17f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
it's just the change from if else to the switch cases. not complicated, I noticed when rebasing. |
Merged into main. |
Currently the tooltips are the item Ids, and the "Quick Links" string (??)
Showing
playlist name #tracks, duration
exactly like in the sidebar may seem redundant but it can be helpful if the sidebar is too narrow to show for long namesIf this is not welcome, let's show nothing, only ids for debugging with
--develper
.