Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar: use item label for tooltip, show id when debugging #4247

Merged
merged 1 commit into from
Aug 28, 2021

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Aug 26, 2021

Currently the tooltips are the item Ids, and the "Quick Links" string (??)

Showing playlist name #tracks, duration exactly like in the sidebar may seem redundant but it can be helpful if the sidebar is too narrow to show for long names

If this is not welcome, let's show nothing, only ids for debugging with --develper.

@ronso0 ronso0 added the ui label Aug 26, 2021
@ronso0
Copy link
Member Author

ronso0 commented Aug 26, 2021

btw, Windows builds fail with

CMake Error at C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.20/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Chromaprint (missing: Chromaprint_LIBRARY
  Chromaprint_INCLUDE_DIR)
Call Stack (most recent call first):
  C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.20/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  cmake/modules/FindChromaprint.cmake:68 (find_package_handle_standard_args)
  CMakeLists.txt:1787 (find_package)

@uklotzde
Copy link
Contributor

Rebase on 2.3?

@ronso0
Copy link
Member Author

ronso0 commented Aug 27, 2021

I consider it a UX inconvenience/inconsistency not really a bug.
but, sure why not..

@ronso0 ronso0 changed the base branch from main to 2.3 August 27, 2021 21:42
src/library/sidebarmodel.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@uklotzde uklotzde merged commit 2d97044 into mixxxdj:2.3 Aug 28, 2021
@ronso0 ronso0 deleted the sidebar-tooltips branch August 28, 2021 17:04
@Be-ing
Copy link
Contributor

Be-ing commented Aug 29, 2021

This created a merge conflict with main. @ronso0 or @uklotzde could you please resolve that?

@ronso0
Copy link
Member Author

ronso0 commented Aug 29, 2021

it's just the change from if else to the switch cases. not complicated, I noticed when rebasing.
I can fix that earliest tomorrow night, like in a day

@uklotzde
Copy link
Contributor

Merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants