Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devendor SoundTouch #4201

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Devendor SoundTouch #4201

merged 1 commit into from
Sep 30, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Aug 14, 2021

Why was this vendored in the first place?

@github-actions github-actions bot added the build label Aug 14, 2021
@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 14, 2021

I guess we don't have SoundTouch in the macOS build environment. Let's remove this after switching to vcpkg for macOS.

@Be-ing Be-ing marked this pull request as draft August 14, 2021 23:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1131447487

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 25.998%
Totals Coverage Status
Change from base Build 1127725238: 0.02%
Covered Lines: 20016
Relevant Lines: 76991
💛 - Coveralls

@daschuer
Copy link
Member

Why was this vendored in the first place?

It was added here:
de76298#diff-a89f5eadda3bbc9d161a7eb01d641c4c2a2b31f534469553251d42ebf3b76632

I guess because it was not part of any distro at that time.
We have continually updated it to a new version, because of important bug fixes not included in the latest bistro versions.

Now it is fine to remove it, because our minimum distro Ubuntu Groovy is has soundtouch 2.1.2 which is one minor release ahead of our internal version. Ubuntu Bionic for Mixxx 2.3 is at 1.9.2 which has assert() which is a bad idea. So we cannot remove soundtouch from the 2.3 tree.

@Holzhaus
Copy link
Member

Ubuntu Bionic for Mixxx 2.3 is at 1.9.2 which has assert() which is a bad idea.

They didn't build it with NDEBUG?

@daschuer
Copy link
Member

I don't know. But that is not really relevant für this PR.

@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 15, 2021

Oof, it turns out the vcpkg port of SoundTouch is awfully broken. It wasn't even installing the headers. Working on it...

@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 16, 2021

Upstream PR to add a CMake build system to SoundTouch: https://gitlab.com/soundtouch/soundtouch/-/merge_requests/11

@Be-ing Be-ing force-pushed the devendor_soundtouch branch from fefe3ba to e06ddba Compare September 30, 2021 06:16
@Be-ing Be-ing marked this pull request as ready for review September 30, 2021 06:17
daschuer
daschuer approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
LGTM

@daschuer daschuer merged commit c8c8eb3 into mixxxdj:main Sep 30, 2021
@Be-ing Be-ing deleted the devendor_soundtouch branch September 30, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Be-ing @coveralls @daschuer @Holzhaus