Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClockControl: Use mixxx::audio::FramePos in updateIndicators() #4190

Merged
merged 1 commit into from
Aug 12, 2021
Merged

ClockControl: Use mixxx::audio::FramePos in updateIndicators() #4190

merged 1 commit into from
Aug 12, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Aug 8, 2021

Based on #4186.

@coveralls
Copy link

coveralls commented Aug 8, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1118024450

  • 55 of 80 (68.75%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 25.994%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/engine/controls/clockcontrol.cpp 52 77 67.53%
Files with Coverage Reduction New Missed Lines %
src/engine/cachingreader/cachingreaderworker.cpp 2 63.48%
src/engine/controls/clockcontrol.cpp 3 72.48%
Totals Coverage Status
Change from base Build 1117978159: -0.01%
Covered Lines: 20012
Relevant Lines: 76988
💛 - Coveralls

@Holzhaus Holzhaus marked this pull request as draft August 8, 2021 22:41
@Holzhaus
Copy link
Member Author

Holzhaus commented Aug 8, 2021

Marked as draft until prerequisite has been merged.

@Holzhaus Holzhaus marked this pull request as ready for review August 10, 2021 22:53
@Holzhaus Holzhaus force-pushed the clockcontrol-framepos branch from f17a481 to 6643b53 Compare August 10, 2021 22:56
uklotzde
uklotzde approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit 0d58e4e into mixxxdj:main Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
code quality
Projects
Semanting Type Refactoring
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Holzhaus @coveralls @uklotzde