lp1937941: Fix update of play counter for different SQLite versions #4152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1081647478
💛 - Coveralls |
uklotzde
changed the title
|
I can no longer replicate the bug using the code in this PR 👍 |
Holzhaus
reviewed
Jul 31, 2021
| // https://www.sqlite.org/lang_update.html#upfrom | ||
| // UPDATE-FROM is supported beginning in SQLite version 3.33.0 (2020-08-14) | ||
| // https://bugs.launchpad.net/mixxx/+bug/1937941 | ||
| #ifdef __SQLITE3__ |
There was a problem hiding this comment.
So if this is not defined, we use Qt's SQLite version which always supports it?
There was a problem hiding this comment.
🤷 I don't know and don't care. Well it's actually simple. The workaround is only used if all conditions are met. Otherwise the default version takes precedence.
daschuer
approved these changes
Aug 6, 2021
This was referenced Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.launchpad.net/mixxx/+bug/1937941
Temporary mitigation to prevent a debug assertion. No time to fix it with a workaround.Fixed.And also fixed an uncovered case for SQLite >= 3.33.0 where the counter was not reset for tracks without any history playlist entry. We need to update twice!
Not going to write any tests. I don't want to touch this code ever after.