Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixxxlibraryfeature: remove wrong ENGINE_PRIME ifdef #4102

Merged
merged 1 commit into from
Jul 12, 2021
Merged

mixxxlibraryfeature: remove wrong ENGINE_PRIME ifdef #4102

merged 1 commit into from
Jul 12, 2021

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jul 12, 2021

otherwise build fails with ENGINEPRIME=OFF

@ronso0 ronso0 added this to the 2.4.0 milestone Jul 12, 2021
Holzhaus
Holzhaus approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. Waiting for CI.

@ronso0 ronso0 added build and removed library labels Jul 12, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1023578209

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 28.642%
Files with Coverage Reduction New Missed Lines %
src/engine/readaheadmanager.cpp 2 88.79%
Totals Coverage Status
Change from base Build 1022999157: -0.001%
Covered Lines: 20098
Relevant Lines: 70170
💛 - Coveralls

@ronso0 ronso0 merged commit 53e774e into mixxxdj:main Jul 12, 2021
@ronso0 ronso0 deleted the mixxxlibraryfeature-include-fix branch July 18, 2021 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

Assignees
No one assigned
Labels
build
Projects
2.4 release
Status: Done
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ronso0 @coveralls @Holzhaus