-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lp1935703: Use nearest frame boundary in lookupBeatPositions() #4095
Merged
daschuer
merged 12 commits into
mixxxdj:main
from
Holzhaus:quantizecontrol-frame-boundary
Jul 11, 2021
+144
−12
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2253c78
FramePos: Add method to rount to upper frame boundary
Holzhaus 015ad88
BeatMap: Allow searching using fractional positions
Holzhaus a69db4b
BeatMapTest: Add test for finding beats with fractional position
Holzhaus decfdbe
BeatMap: Ensure proper frame rounding in hasBeatInRange()
Holzhaus 9284952
FrameTest: Add tests for upper/nearest frame boundary
Holzhaus 730c168
BeatMap: Use camelCase instead of PascalCase for beatLessThan function
Holzhaus 51d077f
BeatMap: Add comment regarding fuzzy matches in hasBeatInRange()
Holzhaus 21b310b
BeatMap: Add tests for hasBeatInRange() with fractional positions
Holzhaus e5a8699
BeatMap: Make beatLessThan helper method inline
Holzhaus 3113dd9
BeatMap: Fix commented out debug assertion
Holzhaus 2d47336
BeatMapTest: Rename countBeatsInIterator to countRemainingBeats
Holzhaus b6e1088
BeatMap: Add comment explaining rounding in findBeats()
Holzhaus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the rational to shrink the range here compared to the original version?
I think a comment would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It this whole function unused? Delete!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry, it is used in WaveformRenderBeat::draw() to find the visible beats in a time range. So it is still required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beats can only appear a full frame positions.
Let's say a beat is at pos 100. If I say "Give me all beats between 100.5 and 200", it should not give me the beat at 100.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2d47336