Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat m4v like m4a for metadata #4088

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Treat m4v like m4a for metadata #4088

merged 1 commit into from
Jul 8, 2021

Conversation

aw-was-here
Copy link
Contributor

This PR is a relatively simple change that allows m4v files to be processed as though they are m4a files when importing file metadata.

@Holzhaus Holzhaus requested a review from uklotzde July 8, 2021 21:21
@uklotzde
Copy link
Contributor

uklotzde commented Jul 8, 2021

Thank you for contributing!

Looks like this has slipped through. We already support decoding of .m4v files with FFmpeg but missed to extend the metadata support. No objections.

As a First-time contributor we have to kindly ask you to sign the Mixxx CLA:

https://docs.google.com/forms/d/e/1FAIpQLScC9QG327sjLL0eWftmfGUasxFFLxg6LCXJ2xHDYRzFIRqyiw/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ

Please comment here when done.

@aw-was-here
Copy link
Contributor Author

Signed. Thanks!

@Be-ing Be-ing merged commit 18624f0 into mixxxdj:main Jul 8, 2021
@aw-was-here aw-was-here deleted the add-m4v branch July 8, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde Awaiting requested review from uklotzde

Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aw-was-here @uklotzde @Be-ing