QML: Add support for dropping tracks on Decks #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
reviewed
Jun 9, 2021
There was a problem hiding this comment.
I'd prefer is someone more familiar with C++ could take a look at that as well before merging.
There is a minor visual issue IMO: the window always indicates an "accepts drop" visual even when over no DropArea. Its slightly confusing, but I don't think we can do anything about that.
uklotzde
approved these changes
Jun 9, 2021
Swiftb0y
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to open a file manager and drag-and-drop a file onto a deck. Tested with nautilus.