Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WMainMenuBar: Fix clazy error #3853

Merged
merged 1 commit into from
May 11, 2021
Merged

WMainMenuBar: Fix clazy error #3853

merged 1 commit into from
May 11, 2021

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde added this to the 2.4.0 milestone May 11, 2021
@uklotzde uklotzde requested review from Holzhaus and ronso0 May 11, 2021 19:58
@uklotzde uklotzde added the ui label May 11, 2021
@ronso0
Copy link
Member

ronso0 commented May 11, 2021

expected with --fullScreen and/or fullscreen option set:

  • launchscreen
  • skin
  • menubar

results are strange, but the same in plain main:

  • with neither --fullScreen nor fullscreen option:

    • starts in window mode
    • launchscreen
    • skin
    • style
  • with the fullscreen option (optional --fullScreen) it works nicely:

    • (other app focused, Mixxx window is pushed to the foreground)
    • launchscreen
    • skin
    • style menubar
  • with --fullScreen only it gets weird (while it works fine in 2.3)

    • starts in window mode
    • (Mixxx window is pushed to the foreground)
    • launchscreen
    • (Alt+Tab to other app)
    • (Mixxx window is pushed to the foreground)
    • unstyled menubar
    • skin
    • style menubarmenubar

@ronso0
Copy link
Member

ronso0 commented May 11, 2021

so, yeah, the change keeps the status quo.
assumption: something related to CoreServices broke the --f arg

same change applied to 2.3 works fine.

Thanks, LGTM

@ronso0 ronso0 merged commit ba13154 into mixxxdj:main May 11, 2021
@uklotzde uklotzde deleted the wmainmenubar-fullscreen branch May 11, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants