Mappings for Pioneer DDJ SB3 Controller #3821

jevilalta · 2021-05-01T23:59:07Z

Hello!

Here is the mapping for the DDJ SB3 controller. I think I've got the prior issues resolved. I have not finished updating the manual yet.

jevilalta · 2021-05-02T16:57:14Z

I've submitted the manual changes: mixxxdj/manual#379

res/controllers/Pioneer-DDJ-SB3-scripts.js

Holzhaus

Thanks, some comments. @Swiftb0y Wanna take another look?

res/controllers/Pioneer-DDJ-SB3-scripts.js

Holzhaus · 2021-05-06T15:21:13Z

res/controllers/Pioneer-DDJ-SB3-scripts.js

+    controlsToFunctions.slipEnabled = "PioneerDDJSB3.slipLed";
+
+    for (i = 1; i <= 8; i++) {
+        controlsToFunctions["hotcue_" + i + "_enabled"] = "PioneerDDJSB3.hotCueLeds";


It's pretty inefficient to update all hotcue LEDS when changing just a single hotcue.

Reviewed this and this particular section is just setting up the mapping of the function to the control, it is not updating / changing the hotcues. This function runs once as part of the init routine.

hotCueLeds function itself only updates one hotcue when called.

Doesn't look like it to me, it iterates over every single hotcue: https://github.com/mixxxdj/mixxx/pull/3821/files/838d17c172d0900ec200843af49479a9d667422c#diff-d5f946ca1b4972678ca7b6f9a6e80d25c1ad128ab7986944d89409e3ebd425c2R1222

Swiftb0y · 2021-05-06T15:25:54Z

Yes, Started my review yesterday, but I'm not sure when it'll be finished.

Swiftb0y

Thanks for submitting your mapping. I'm not yet finished reviewing but these are my remarks on the first 1150 lines.

res/controllers/Pioneer-DDJ-SB3.midi.xml

res/controllers/Pioneer-DDJ-SB3-scripts.js

Swiftb0y · 2021-05-07T17:14:47Z

res/controllers/Pioneer-DDJ-SB3-scripts.js

+PioneerDDJSB3.deckSwitchTable = {
+    "[Channel1]": "[Channel1]",
+    "[Channel2]": "[Channel2]",
+    "[Channel3]": "[Channel3]",
+    "[Channel4]": "[Channel4]"
+
+};
+
+PioneerDDJSB3.deckShiftSwitchTable = {
+    "[Channel1]": "[Channel3]",
+    "[Channel2]": "[Channel4]",
+    "[Channel3]": "[Channel1]",
+    "[Channel4]": "[Channel2]"
+};
+
+PioneerDDJSB3.deckIndexTable = {
+    "[Channel1]": 0,
+    "[Channel2]": 1,
+    "[Channel3]": 2,
+    "[Channel4]": 3
+};


Whats the purpose of this?

This is to support the 4 deck configuration. The controller only has 2 physical decks but when you select the deck 3 and 4, other "virtual" decks are enabled. These lookup tables are used to handle the shifted decks.

That said, the deckIndexTable isn't needed so I've removed that.

Mhmm. I understand, its just a weird way to implement it.

res/controllers/Pioneer-DDJ-SB3-scripts.js

uklotzde · 2021-05-13T21:11:47Z

Thanks for signing the contributor agreement ✔️

It would be cool if we could merge this PR before releasing 2.3.0. Do you have time to resolve the review comments?

jevilalta · 2021-05-15T14:39:46Z

Thanks for signing the contributor agreement ✔️

It would be cool if we could merge this PR before releasing 2.3.0. Do you have time to resolve the review comments?

I will make the changes this weekend. I am finishing up the manual changes. I will submit that today and move on to this.

uklotzde · 2021-05-20T12:53:21Z

A minor code style issue left to fix.

@Holzhaus The manual PR mixxxdj/manual#379 is almost ready? Only a link check failure.

uklotzde · 2021-05-20T12:55:10Z

...and some unresolved comments by @Swiftb0y.

jevilalta · 2021-09-08T22:12:52Z

Any progress on this? Rescheduling to 2.3.2.

I haven't made any progress. I'm still limited on time, I'm happy to transfer the repo over if anyone is interested.

Seems I would need to rebase onto the 2.3.2 branch then, in order to continue working on this and change the target branch of the PR? Can you confirm?

Be-ing · 2021-09-08T22:14:04Z

We don't make separate branches for minor releases; we only make new Git tags. We will keep using the 2.3 branch. So there is no need to rebase.

jevilalta · 2021-12-01T01:11:02Z

Hi, I am done with the changes requested. Let me know if I missed anything.

Swiftb0y

Thanks, last comment, LGTM otherwise.

res/controllers/Pioneer-DDJ-SB3-scripts.js

Be-ing · 2021-12-18T23:57:57Z

I trust @Swiftb0y and @Holzhaus to have sufficiently reviewed the code here. The only glaring issue is the lack of access to hotcues 5-8. When that is fixed and the pending review comments on the documentation are resolved, let's merge this.

jevilalta · 2021-12-26T20:55:17Z

I have pushed the update which enables hotcues 5-8. I will move on to fixing the documentation.

jevilalta · 2021-12-28T17:27:19Z

i think that's the last of the requested changes, but lmk if anything else needs to be changed

Swiftb0y · 2022-01-09T14:51:48Z

pre-commit is complaining about trailing whitespace in your XML. It's not really an issue, but I'd prefer to merge without precommit complaining.

Swiftb0y

Thank you very much for mapping this controller. It'll likely be released in Mixxx 2.3.2

travstone · 2022-02-03T05:33:37Z

Am I doing something wrong, or does this mapping still not work for decks 3/4 when you're using an external soundcard?

I read somewhere else that one might be able to launch mixxx with the DDJ-SB3 internal soundcard selected (which does seem to work) and then switch back to the external card, but I almost immediately got an error:

Uncaught exception at line 308 in file C:/Program Files/Mixxx/controllers/Pioneer-DDJ-SB3-scripts.js.

Exception:
  TypeError: Result of expression 'PioneerDDJSB3.headphoneLevel' [undefined] is not an object.

Backtrace:
  <anonymous>(channel = 0, control = 63, value = 0, status = 144, group = '[Channel1]') at C:/Program Files/Mixxx/controllers/Pioneer-DDJ-SB3-scripts.js:308
  <anonymous>(arg1 = 0, arg2 = 63, arg3 = 0, arg4 = 144, arg5 = '[Channel1]') at 1
  <global>() at -1

I got this error once before when I tried to use the shift button to change the decks (prior to trying the trick of changing the soundcard), but I also got it again after. In that second case, I had hit the shift button to use the platter to skip forward quickly. After that the deck button stopped being illuminated and I was no longer able to select decks 3/4.

Not sure this is enough info to be helpful, but I'll try to replicate the steps more carefully later.

Also, just want to know if there's something else I should be doing to make the deck 3/4 switching work correctly. Thanks for all your work on this!

Swiftb0y · 2022-02-03T10:23:09Z

@travstone
Thank you for making us aware of this issue. Looking at the code, the problem should occur everytime the shift button is released, so I'm wondering why this has not been noticed sooner.
If you just remove line 308 (this one: PioneerDDJSB3.headphoneLevel.unshift();) it should work. Could you try that and see if it fixes the issue?
Thanks

travstone · 2022-02-03T16:41:22Z

@Swiftb0y confirmed; when I comment that line I no longer get an error for either of the cases, all good there.

add mappings for Pioneer DDJ SB3

838d17c

github-actions bot added the controller mappings label May 1, 2021

ronso0 added this to the 2.3.0 milestone May 2, 2021

jevilalta mentioned this pull request May 2, 2021

Add Pioneer DDJ SB3 documentation mixxxdj/manual#379

Merged

Swiftb0y self-assigned this May 5, 2021

Holzhaus reviewed May 6, 2021

View reviewed changes

res/controllers/Pioneer-DDJ-SB3-scripts.js Outdated Show resolved Hide resolved

Holzhaus reviewed May 6, 2021

View reviewed changes

res/controllers/Pioneer-DDJ-SB3-scripts.js Outdated Show resolved Hide resolved

Holzhaus reviewed May 6, 2021

View reviewed changes

Swiftb0y requested changes May 7, 2021

View reviewed changes

jevilalta added 9 commits May 15, 2021 10:46

remove license notice

82be65d

fix eslint warning

dd457b2

reference functions directly

44909b5

fix mixxx min version

7dbc374

add wiki, manual and forums information

4b6cb21

remove unused setting

67ab07c

pass in actual function

46b7cc9

fix redeclare issue

b1c796c

remove copyright notice

fa8de7b

jevilalta added 4 commits May 22, 2021 13:58

reorder and style fix

ef14382

reorder and fix style

82d9923

remove unused property

f187301

consolidate function code

e15325c

uklotzde added this to the 2.3.2 milestone Sep 7, 2021

jevilalta added 7 commits October 2, 2021 09:39

add comment to clarify use of component

46f6fc5

fix line endings

97a9c64

remove flashing of play button while paused

47fbd7d

remove non-standard uses of knobs

11b2255

add improvement suggestion

0ff4bea

replace padmode magic numbers with "enum"

a015f27

fix version

96ae21f

Swiftb0y reviewed Dec 1, 2021

View reviewed changes

res/controllers/Pioneer-DDJ-SB3-scripts.js Outdated Show resolved Hide resolved

Swiftb0y added the changelog This PR should be included in the changelog label Dec 1, 2021

move padmode after user options

34e65a3

jevilalta added 2 commits December 26, 2021 14:47

enable hotcues 5-8

7e52ecc

fix spelling

e359977

remove mapping of the haedphones and master levels

51985e7

fix spelling

27b5a54

fix whitespace

f05dcf2

Holzhaus requested a review from Swiftb0y January 9, 2022 23:03

Swiftb0y approved these changes Jan 10, 2022

View reviewed changes

Swiftb0y merged commit f76fe15 into mixxxdj:2.3 Jan 10, 2022

jevilalta deleted the Pioneer-DDJ-SB3 branch January 10, 2022 19:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mappings for Pioneer DDJ SB3 Controller #3821

Mappings for Pioneer DDJ SB3 Controller #3821

jevilalta commented May 1, 2021

jevilalta commented May 2, 2021

Holzhaus left a comment

Holzhaus May 6, 2021

jevilalta May 15, 2021

Holzhaus May 18, 2021

Swiftb0y commented May 6, 2021

Swiftb0y left a comment

Swiftb0y May 7, 2021

jevilalta May 22, 2021

Swiftb0y May 23, 2021

uklotzde commented May 13, 2021

jevilalta commented May 15, 2021

uklotzde commented May 20, 2021

uklotzde commented May 20, 2021

jevilalta commented Sep 8, 2021

Be-ing commented Sep 8, 2021 •

edited

Loading

jevilalta commented Dec 1, 2021

Swiftb0y left a comment

Be-ing commented Dec 18, 2021

jevilalta commented Dec 26, 2021 •

edited

Loading

jevilalta commented Dec 28, 2021

Swiftb0y commented Jan 9, 2022

Swiftb0y left a comment

travstone commented Feb 3, 2022

Swiftb0y commented Feb 3, 2022

travstone commented Feb 3, 2022

Mappings for Pioneer DDJ SB3 Controller #3821

Mappings for Pioneer DDJ SB3 Controller #3821

Conversation

jevilalta commented May 1, 2021

jevilalta commented May 2, 2021

Holzhaus left a comment

Choose a reason for hiding this comment

Holzhaus May 6, 2021

Choose a reason for hiding this comment

jevilalta May 15, 2021

Choose a reason for hiding this comment

Holzhaus May 18, 2021

Choose a reason for hiding this comment

Swiftb0y commented May 6, 2021

Swiftb0y left a comment

Choose a reason for hiding this comment

Swiftb0y May 7, 2021

Choose a reason for hiding this comment

jevilalta May 22, 2021

Choose a reason for hiding this comment

Swiftb0y May 23, 2021

Choose a reason for hiding this comment

uklotzde commented May 13, 2021

jevilalta commented May 15, 2021

uklotzde commented May 20, 2021

uklotzde commented May 20, 2021

jevilalta commented Sep 8, 2021

Be-ing commented Sep 8, 2021 • edited Loading

jevilalta commented Dec 1, 2021

Swiftb0y left a comment

Choose a reason for hiding this comment

Be-ing commented Dec 18, 2021

jevilalta commented Dec 26, 2021 • edited Loading

jevilalta commented Dec 28, 2021

Swiftb0y commented Jan 9, 2022

Swiftb0y left a comment

Choose a reason for hiding this comment

travstone commented Feb 3, 2022

Swiftb0y commented Feb 3, 2022

travstone commented Feb 3, 2022

Be-ing commented Sep 8, 2021 •

edited

Loading

jevilalta commented Dec 26, 2021 •

edited

Loading