Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend compatible keys from 4 to 6 possible keys #3205

Merged
merged 3 commits into from
Oct 23, 2020
Merged

Extend compatible keys from 4 to 6 possible keys #3205

merged 3 commits into from
Oct 23, 2020

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde added this to the 2.4.0 milestone Oct 22, 2020
@github-actions github-actions bot removed the library label Oct 22, 2020
daschuer
daschuer approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.
I consider this a bug that schould be backported to 2.2.
For many tracks it is ambiguous if they are minor or minor or even something else.
The more is kind of random in this case.

Tests are failing now.

@uklotzde uklotzde modified the milestones: 2.4.0, 2.2.5 Oct 23, 2020
@uklotzde uklotzde changed the base branch from main to 2.2 October 23, 2020 08:15
@uklotzde uklotzde marked this pull request as ready for review October 23, 2020 08:16
@uklotzde
Copy link
Contributor Author

Sorry, I forgot to update the tests before publishing this quick fix.

@uklotzde uklotzde requested a review from daschuer October 23, 2020 08:16
daschuer
daschuer requested changes Oct 23, 2020
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Please also add a CHANGELOG entry.

@uklotzde uklotzde requested a review from daschuer October 23, 2020 11:38
daschuer
daschuer approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you.

@daschuer daschuer merged commit 6f2ad03 into mixxxdj:2.2 Oct 23, 2020
@uklotzde uklotzde deleted the compatible_keys branch October 24, 2020 20:32
@uklotzde uklotzde modified the milestones: 2.2.5, 2.3.0 May 11, 2021
@mixxxbot mixxxbot mentioned this pull request Aug 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
code quality minor bug
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@uklotzde @daschuer @Holzhaus