Remove TrackId from Cue #3016
Merged
Remove TrackId from Cue #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
suggested changes
Aug 14, 2020
|
Sorry, old habits. I am used to cleaning up stuff along the way, mostly worked on personal projects previously :) |
xeruf
force-pushed
the
cue-trackid
branch
2 times, most recently
from
f5179a9 to
b3f7fa1
Compare
uklotzde
suggested changes
Aug 18, 2020
xeruf
force-pushed
the
cue-trackid
branch
4 times, most recently
from
2b1cbd7 to
b3f7fa1
Compare
|
Sorry, I didn't trust them lately as I have seen too many CI failures ^^ And sorry for all the force-pushing, that was somewhat accidental... Should be all fine now. |
uklotzde
approved these changes
Aug 18, 2020
|
You could have noticed the build failures locally by enabling The final changeset is clean and matches the goal. Please avoid changing unrelated code in the future. Thank you for fixing this legacy issue. Sometimes a different viewpoint is needed to spot obvious design flaws. LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quickie I found while talking with Jan, trying to understand db sync :)
The Cue shouldn't know it's owner, the Track, and it doesn't even need to - voila 🎉
I am kinda wondering whether we need the
unsetId/resetId method at all, since the Track is about to be deleted anyways when this is called. But I don't know enough about the TrackRecord lifecycle for that.