Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shoutcast_internal always 0 bug in master #2438

Merged
merged 5 commits into from
Jan 20, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bump minimum shoutcast version to 2.4.4, because 2.4.3 is still affec…
…ted from: lp1833225
  • Loading branch information
daschuer committed Jan 15, 2020
commit 7600c12c71d8254de754abb0e9e6ef23b806dbee
4 changes: 2 additions & 2 deletions build/features.py
Original file line number Diff line number Diff line change
@@ -835,9 +835,9 @@ def configure(self, build, conf):
build.env.Append(CPPDEFINES='__BROADCAST__')

if build.platform_is_linux and not int(build.flags['shoutcast_internal']):
# Check if system lib is lower 2.4.2 or 2.4.3 and not suffering bug
# Check if system lib is lower 2.4.2 or at least 2.4.4 and not suffering bug
# https://bugs.launchpad.net/mixxx/+bug/1833225
if not conf.CheckForPKG('shout', '2.4.3'):
if not conf.CheckForPKG('shout', '2.4.4'):
if conf.CheckForPKG('shout', '2.4.2'):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it, do package maintainers rebuild all dependant packages if a library is updated? If not, maybe we should always use internal libshout if the version is below 2.4.4 even if 2.4.1 is currently installed?

print("System's libshout 2.4.2 suffers lp1833225, using internal shout_mixxx")
build.flags['shoutcast_internal'] = 1