Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(effects): update EffectSlot meta default value according to loaded effect #12480

Merged
merged 1 commit into from
Dec 30, 2023
Merged

fix(effects): update EffectSlot meta default value according to loaded effect #12480

merged 1 commit into from
Dec 30, 2023

Conversation

Swiftb0y
Copy link
Member

Fixes #12479

@Swiftb0y
Copy link
Member Author

local build finished and works flawlessly as far as I can tell.

@Swiftb0y Swiftb0y marked this pull request as ready for review December 30, 2023 00:53
@Swiftb0y Swiftb0y added this to the 2.4.0 milestone Dec 30, 2023
ronso0
ronso0 approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ronso0 ronso0 linked an issue Dec 30, 2023 that may be closed by this pull request
Default value (using right click) for "Moog filter" #12479
Closed
@ronso0 ronso0 merged commit 71dceb2 into mixxxdj:2.4 Dec 30, 2023
13 checks passed
@Swiftb0y Swiftb0y deleted the feat/gh12479-effect-meta-knob-default-value branch December 30, 2023 11:04
@Swiftb0y
Copy link
Member Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronso0 ronso0 ronso0 approved these changes

Assignees
No one assigned
Labels
effects
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Default value (using right click) for "Moog filter"
2 participants
@Swiftb0y @ronso0