Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 500ms blocking of the whole event loop, when holding mouse down on title bar on Windows #12359

Merged
merged 4 commits into from
Nov 26, 2023

Conversation

@github-actions github-actions bot added the build label Nov 26, 2023
@JoergAtGithub JoergAtGithub force-pushed the nativeEventHandlerWindows branch from 1b70fbe to bd0bf34 Compare November 26, 2023 10:43
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the nice fix. I have added some comments about improved code maintenance.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
src/nativeeventhandlerwin.cpp Show resolved Hide resolved
src/nativeeventhandlerwin.cpp Show resolved Hide resolved
@JoergAtGithub
Copy link
Member Author

All suggestions implemented!

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 91fc002 into mixxxdj:2.4 Nov 26, 2023
12 checks passed
@JoergAtGithub JoergAtGithub deleted the nativeEventHandlerWindows branch November 26, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants