-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pref Sound: auto select free device channels #11859
Pref Sound: auto select free device channels #11859
Conversation
f3cc4d2
to
01edc97
Compare
01edc97
to
e47f4c5
Compare
51abef3
to
8a2bce1
Compare
8a2bce1
to
550fba2
Compare
I like this, it makes the common case very convenient, though I think it could also feel a bit "magical", especially if the user has a more esoteric device/channel configuration. |
Thanks for testing this! Note that the occupied channel indices are stored per device so it won't suggest weird channels for formerly unconfigured devices. |
It's working nicely, didn't encounter any hickups, incl. Query Devices. Ready for review. |
10d47b2
to
cd1f858
Compare
bump |
ba-bump |
Just tested this and it works very neat with my Traktor Z2 (2xOut Ch + 4x In Ch in unusual order) accross all the Windows Audio driver APIs. |
cd1f858
to
a50fca9
Compare
Thanks for your review @JoergAtGithub ! |
LGTM! Thank you! |
I started another coffee break project to add little helper:
when you need to configure multiple sound outputs using one device, like channels 1-2 for Main & 3-4 for headphones as with many controller soundcards, and you configured the first output it is very pleasant if the next free channel pair is selected automatically for the second output.
That saves one click (yeaiiy!!), but more importantly: it avoids mis(re-)configuration in the Heat of the Night:tm: (assign same channels twice, Apply, error, meeeh, select correct channels, Apply).
Note: this does just combobox index matching, i.e. does not check channel overlap like
Mic1: channel 1, Aux1: channels 1-2.
Closes #10163
This is still WIP but it's working nicely already.
I'll do more testing and polish it.