Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update launchpad links in js #11379

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Update launchpad links in js #11379

merged 3 commits into from
Mar 17, 2023

Conversation

daschuer
Copy link
Member

This is the follow up of #11377
Including the commits to make eslint happy. This is not tested.

@daschuer daschuer mentioned this pull request Mar 16, 2023
Merged
@ronso0
Copy link
Member

ronso0 commented Mar 16, 2023

now one mapping test fails:
120 - LegacyControllerMappingValidationTest.MidiMappingsValid (Failed)

@daschuer daschuer force-pushed the update-launchpad-links-js branch from adfbcf1 to 034d4ae Compare March 16, 2023 09:55
@daschuer daschuer force-pushed the update-launchpad-links-js branch from 034d4ae to 8db4060 Compare March 17, 2023 07:57
@daschuer
Copy link
Member Author

All green now. Can one JS expert have a brief look before merge?

@ronso0
Copy link
Member

ronso0 commented Mar 17, 2023

All green now. Can one JS expert have a brief look before merge?

@Swiftb0y @JoergAtGithub ?

Swiftb0y
Swiftb0y approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the mappings themselves are quite outdated but thats outside the scope of this PR. as long as they pass eslint and the smoketest, they should still work.

@Swiftb0y Swiftb0y merged commit ddf11e4 into mixxxdj:2.4 Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
controller mappings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daschuer @ronso0 @Swiftb0y