Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Buffer Jack: Auto/2048/4096 #11366

Merged
merged 13 commits into from
Mar 18, 2023
Merged

Audio Buffer Jack: Auto/2048/4096 #11366

merged 13 commits into from
Mar 18, 2023

Conversation

daschuer
Copy link
Member

This fixes #11341

The issue was that the configured buffer was to small when selecting a big JACK buffer.
Unfortunately we receive the actual JACK buffer size via the Engine thread only, so we need to allocate the new buffer in the engine thread. But this is OK, because this will only happen during the very fist callback.

@JoergAtGithub
Copy link
Member

LGTM

@daschuer daschuer marked this pull request as draft March 15, 2023 15:58
@daschuer daschuer marked this pull request as ready for review March 18, 2023 11:30
@daschuer
Copy link
Member Author

Now the issue is solved. I have pipewire installed and can select various buffers while Mixxx is running with:
pw-metadata -n settings 0 clock.force-quantum 1024
for testing,

grafik
.. is now the default. And it starts counting underflows if you configure Jack to more than 1024 frames/period.
In this case you have to explicit adjust Mixxx/Portaudio for the selected buffer size.

src/soundio/soundmanagerconfig.cpp Outdated Show resolved Hide resolved
@daschuer daschuer changed the title Adjust network device buffers dynamically Audio Buffer Jack: Auto/2048/4096 Mar 18, 2023
@JoergAtGithub JoergAtGithub added this to the 2.3.5 milestone Mar 18, 2023
@daschuer
Copy link
Member Author

Done.

Co-authored-by: JoergAtGithub <[email protected]>
@JoergAtGithub
Copy link
Member

Last CI run was Pass and only a typo in a comment was changed in last commit -> no reason to wait for CI to complete.
Thank you!

@JoergAtGithub JoergAtGithub merged commit 9080c7e into mixxxdj:2.3 Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants