-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio Buffer Jack: Auto/2048/4096 #11366
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
…d values above 1024 where auto does not work.
JoergAtGithub
requested changes
Mar 18, 2023
daschuer
changed the title
Adjust network device buffers dynamically
Audio Buffer Jack: Auto/2048/4096
Mar 18, 2023
…ateAudioBufferSizes()
Done. |
JoergAtGithub
approved these changes
Mar 18, 2023
Co-authored-by: JoergAtGithub <[email protected]>
Last CI run was Pass and only a typo in a comment was changed in last commit -> no reason to wait for CI to complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11341
The issue was that the configured buffer was to small when selecting a big JACK buffer.
Unfortunately we receive the actual JACK buffer size via the Engine thread only, so we need to allocate the new buffer in the engine thread. But this is OK, because this will only happen during the very fist callback.