Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Latenight skin quick effect toggle controls only affecting the first effect of the chain #11135

Merged

Conversation

robbert-vdh
Copy link
Contributor

I noticed that the quick effect chain bypass wasn't working correctly for effect chain presets with multiple effects (and setting the correct value from my controller didn't result in any visible feedback in the GUI). The other skins seem to already do the right thing here, so this was probably just an oversight.

In the Latenight skin when clicking on the bypass buttons next to the
quick effect super knobs.
@github-actions github-actions bot added the skins label Dec 19, 2022
@robbert-vdh
Copy link
Contributor Author

The QuickEffect variable is also used for checking whether the chain is enabled. That's not the correct behavior for effect chains where the first slot is unused. I don't know if there's a better way to detect that the effect chain has finished loading, or if the knob should be hidden at all if it isn't.

@ronso0
Copy link
Member

ronso0 commented Dec 20, 2022

Thanks for the fix! That is obviously a leftover and I wonder why it wasn't discovered earlier...

Here's the commit that fixes the knob/button visibility conection c0acd2b
Note that after merging #10859 0 needs to be change to 1

or if the knob should be hidden at all if it isn't.

well, we may discuss that again. IIRC that's LateNight legacy behaviour and I appreciate it since it allows a clean UI in case you never use QuickEffects (like I do), it's simply one less thing to care about.

@robbert-vdh
Copy link
Contributor Author

Oh awesome! I've already redone my effect chains so that the first effect is always used (I liked keeping the middle one as a filter so I can easily add something before or after it when saving a new preset), but it's nice to not have to do that ha.

@ronso0
Copy link
Member

ronso0 commented Dec 21, 2022

Great : )

Here's the commit that fixes the knob/button visibility conection c0acd2b

Feel free to pick that for this PR.

@robbert-vdh
Copy link
Contributor Author

Done.

@ronso0
Copy link
Member

ronso0 commented Dec 21, 2022

Thanks.
I'll remove the leftover variables in a separate commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants