Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding edge case of MIDI mapping for Ableton Push #10905

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

Replayman
Copy link
Contributor

Hi,
This is a little code update to take into account another edge case of MIDI in / MIDI out controller with different mappings.

As of today, I wasn't able to deploy a working dev and build environment to verify compilation of MIXXX with this update (harder under Windows...) but here is it anyway as this is only a few lines of code.

@Replayman
Copy link
Contributor Author

Replayman commented Sep 18, 2022

Here is the developer log at MIXXX startup for these 2 devices:

Debug [Controller]: Scanning PortMIDI devices:
Debug [Controller]: Found output device # 0 Microsoft MIDI Mapper
Debug [Controller]: Found output device # 3 Microsoft GS Wavetable Synth
Debug [Controller]: Found output device # 4 Ableton Push
Debug [Main]: BaseTrackPlayerImpl::slotLoadTrack "[Sampler1]" QObject(0x0)
Debug [Controller]: Found output device # 5 MIDIOUT2 (Ableton Push)
Debug [Controller]: Found input device # 1 Ableton Push
Debug [Controller]: Linking to output device # 4 "Ableton Push"
Debug [Controller]: Found input device # 2 MIDIIN2 (Ableton Push)
Debug [Controller]: Scanning HSS1394 devices:
Debug [Controller]: Nodes detected: 0
Debug [Controller]: Scanning HID devices:

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I cannot test this, the changes are looking reasonable.

@daschuer
Copy link
Member

Thank you very much for your fist contribution.
Before merge, we need your permission.
Please sign https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ
and comment here when done.

@Replayman
Copy link
Contributor Author

Thank you very much for your fist contribution. Before merge, we need your permission. Please sign https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ and comment here when done.

Signed, thank you.

@daschuer daschuer merged commit d316b0d into mixxxdj:2.3 Sep 20, 2022
@daschuer
Copy link
Member

Thank you! I like to add your name to the contributor list in the Mixxx About Box. Should I use your GitHub User name or your real name?

@ronso0 ronso0 added this to the 2.3.4 milestone Sep 20, 2022
@Replayman
Copy link
Contributor Author

Thank you! I like to add your name to the contributor list in the Mixxx About Box. Should I use your GitHub User name or your real name?

My real name please, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants