Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch metadata from MusicBrainz with adaptive rate limiting #10874

Merged
merged 5 commits into from
Sep 7, 2022
Merged

Fetch metadata from MusicBrainz with adaptive rate limiting #10874

merged 5 commits into from
Sep 7, 2022

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Sep 7, 2022 •
edited
Loading

Alternative implementation for #10836 without all the unrelated and questionable changes. I can no longer bother @Swiftb0y with this controversial discussion, letting him stand in the line of fire.

Just works:

debug [Main] mixxx::network::WebTask - mixxx::MusicBrainzRecordingsTask(0x7fffd8065980) Starting...
debug [Main] mixxx::network::WebTask - mixxx::MusicBrainzRecordingsTask(0x7fffd8065980) Received reply for request QUrl("https://musicbrainz.org/ws/2/recording/48b1c0fd-e0e9-48b8-9c22-81f6cc8d0252?inc=artists+artist-credits+releases+release-groups+media")
debug [Main] mixxx::network::WebTask - mixxx::MusicBrainzRecordingsTask(0x7fffd8065980) Received network reply after 511 ms
debug [Main] mixxx::network::WebTask - mixxx::MusicBrainzRecordingsTask(0x7fffd8065980) Scheduling next request after 487 ms
debug [Main] mixxx::network::WebTask - mixxx::MusicBrainzRecordingsTask(0x7fffd8065980) Starting...
debug [Main] mixxx::network::WebTask - mixxx::MusicBrainzRecordingsTask(0x7fffd8065980) Received reply for request QUrl("https://musicbrainz.org/ws/2/recording/fed2b990-7344-4584-a4fa-685158a410eb?inc=artists+artist-credits+releases+release-groups+media")
debug [Main] mixxx::network::WebTask - mixxx::MusicBrainzRecordingsTask(0x7fffd8065980) Received network reply after 94 ms

The adaptive rate limiting changes can be found in the last commit, straightforward as predicted.

daschuer
daschuer requested changes Sep 7, 2022
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

src/musicbrainz/web/musicbrainzrecordingstask.cpp Outdated Show resolved Hide resolved
src/musicbrainz/web/musicbrainzrecordingstask.cpp Outdated Show resolved Hide resolved
@Swiftb0y
Copy link
Member

Swiftb0y commented Sep 7, 2022

Thank you @uklotzde for taking over. I'm sorry I couldn't keep up with #10874, I'm too busy atm with wrapping up gsoc and irl.

@daschuer daschuer merged commit 11d6608 into mixxxdj:2.3 Sep 7, 2022
@uklotzde uklotzde deleted the uklotzde-musicbrainz-ratelimit-patch branch September 7, 2022 23:28
@daschuer daschuer mentioned this pull request Sep 8, 2022
Closed
@Swiftb0y Swiftb0y mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uklotzde @Swiftb0y @daschuer @fatihemreyildiz